Avi Kivity wrote:
On 12/10/2010 03:51 PM, Andre Przywara wrote:
Newer SVM implementations provide the GPR number in the VMCB, so
that the emulation path is no longer necesarry to handle debug
register access intercepts. Implement the handling in svm.c and
use it when the info is provided.
+
+ if (!err)
+ skip_emulated_instruction(&svm->vcpu);
+ else
+ kvm_inject_gp(&svm->vcpu, 0);
+
This repeats, how about using complete_insn_gp()?
Do you want this to be in x86.c? We could use
kvm_x86_ops->skip_emulated_instruction.
Also shall I look for more similarities in the [CD]R intercept handling
code between VMX and SVM? The switch responsible for actually reading
and writing the regs is very similar. I could also try to merge this
with the functionality in the emulator (if that works, haven't checked)
Regards,
Andre.
--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
