On Mon, Dec 06, 2010 at 02:37:05PM -0200, Thiago Farina wrote: > On Mon, Nov 29, 2010 at 3:16 PM, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: > > +#define container_of(ptr, type, member) ({ \ > > + const typeof( ((type *)0)->member ) *__mptr = (ptr); \ > > + (type *)( (char *)__mptr - offsetof(type,member) );}) > > + > > +#define uninitialized_var(x) x = x > > + > > +# ifndef likely > > +# define likely(x) (__builtin_expect(!!(x), 1)) > > +# endif > > +# ifndef unlikely > > +# define unlikely(x) (__builtin_expect(!!(x), 0)) > > +# endif > > It seems you are not using these macros. Do you really need them here? They are used by virtio that I'm compiling in userspace here. > Can't you include the right linux header files for these macros > instead? Far from trivial as linux headers aren't intended to be built in userspace, if you try you get all kind of conflicts with libc headers etc. If you see a way to do this, pls send me a patch. -- MST -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html