On Mon, Dec 06, 2010 at 05:29:24PM -0200, Marcelo Tosatti wrote: > On Fri, Dec 03, 2010 at 11:45:52AM +0100, Joerg Roedel wrote: > > This patch implements the clean-bit for all interrupt > > related state in the vmcb. This corresponds to vmcb offset > > 0x60-0x67. > > > > Signed-off-by: Joerg Roedel <joerg.roedel@xxxxxxx> > > Don't you have to mark dirty on sync_lapic_to_cr8? In theory yes, but sync_lapic_to_cr8 is called in every vmexit/vmrun cycle. Thats why I added the interrupt bit to the always-dirty mask. I left this as a future optimization to only write cr8 to the vmcb when it actually changes. Joerg -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html