On 12/06/2010 12:22 PM, Xiao Guangrong wrote:
Hi Avi, On 12/06/2010 05:48 PM, Avi Kivity wrote: > On 12/02/2010 11:46 AM, Xiao Guangrong wrote: >> Retry #PF for softmmu only when the current vcpu has the same cr3 as >> the time >> when #PF occurs >> >> Changelog: >> Just compare cr3 value since It's harmless to instantiate an spte >> for an >> unused translation from Marcelo's comment >> > > It's not harmless. We could be in a different process, so we have to > re-fetch the gpte. Or we could have switched from one nested guest to > another. > But it does this in this patch: re-walk guest page table and fixes guest's shadow page (not use any info when apf is occurred)
Right. Please resend without the walk_addr() changes. While they're correct, I'd like to keep that part simpler.
-- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
