Am 29.11.2010 09:59, schrieb Kevin Wolf: > Am 27.11.2010 08:12, schrieb Stefan Hajnoczi: >> On Fri, Nov 26, 2010 at 9:59 PM, Christian Brunner >> <c.m.brunner@xxxxxxxxx> wrote: >>> Thanks for the review. What am I supposed to do now? >> >> Kevin is the block maintainer. His review is the next step, I have >> CCed him. After that rbd would be ready to merge. > > If I don't find anything really obvious and it doesn't break the build, > I'll merge it based on your review. Which librados version is this supposed to require? My F12 one seems to be too old, however configure still automatically enables it (so the build fails in the default configuration for me). I think you need to add some check there. $ rpm -q ceph-devel ceph-devel-0.20.2-1.fc12.x86_64 $ LANG=C make CC block/rbd.o block/rbd.c: In function 'rbd_register_image': block/rbd.c:191: error: 'CEPH_OSD_TMAP_SET' undeclared (first use in this function) block/rbd.c:191: error: (Each undeclared identifier is reported only once block/rbd.c:191: error: for each function it appears in.) cc1: warnings being treated as errors block/rbd.c: In function 'rbd_set_snapc': block/rbd.c:468: error: implicit declaration of function 'rados_set_snap_context' block/rbd.c:468: error: nested extern declaration of 'rados_set_snap_context' block/rbd.c: In function 'rbd_snap_create': block/rbd.c:844: error: implicit declaration of function 'rados_selfmanaged_snap_create' block/rbd.c:844: error: nested extern declaration of 'rados_selfmanaged_snap_create' make: *** [block/rbd.o] Error 1 Kevin -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
