On Sun, Nov 28, 2010 at 11:38:36AM +0200, Avi Kivity wrote: > On 11/28/2010 09:54 AM, Gleb Natapov wrote: > >On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: > >> On 11/23/2010 06:12 PM, Anthony Liguori wrote: > >> >On 11/23/2010 09:31 AM, Gleb Natapov wrote: > >> >>Anthony, Blue > >> >> > >> >>No comments on this patch series for almost a week. Can it be applied? > >> > > >> >Does that mean everyone's happy or have folks not gotten around to > >> >review it? > >> > > >> >IOW, last call if you have objections :-) > >> > > >> > >> I haven't reviewed this - I trust the author and maintainers to get > >> it right. > >> > >> But I notice the there is no documentation - surely some is needed? > >> > > > >The patch creates Openfirmware device path from qdev > >hierarchy. Each element of a device path depends on type of a bus > >the device resides on. You can find various bus bindings here: > >http://playground.sun.com/1275/bindings/ and main spec is here > >http://forthworks.com/standards/of1275.pdf. Format in which list of > >device paths is passed to firmware is documented by comment (it is very > >simple). The only thing missing is command line option documentation. I > >will add it and resend if no more changes are needed for patch to be > >excepted. > > What about the format of the fwcfg interface? It should be > described, and point to the references above. > As I said above it is described in a comment above get_boot_devices_list(). No pointers to Openfirmware there, will put them above get_fw_dev_path() definition in qdev.h where they belong. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
