Re: [PATCH] KVM: VMX: Fold __vmx_vcpu_run() into vmx_vcpu_run()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/18/2010 05:00 PM, Andi Kleen wrote:
On 11/18/2010 3:32 PM, Avi Kivity wrote:
On 11/18/2010 03:48 PM, Andi Kleen wrote:
On 11/18/2010 1:17 PM, Avi Kivity wrote:
cea15c2 ("KVM: Move KVM context switch into own function") split vmx_vcpu_run() to prevent multiple copies of the context switch from being generated (causing problems due to a label). This patch folds them back together again and adds
the __noclone attribute to prevent the label from being duplicated.

That won't work on gcc versions that didn't have __noclone yet. Noclone is fairly recent
(4.5 or 4.4)

Are the gcc versions that don't have noclone susceptible to cloning?

I believe the problem can happen due to inlining already

vmx_vcpu_run() cannot be inlined (it is only called via a function pointer; call site is in a different module)

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux