On Mon, Nov 15, 2010 at 9:04 AM, Christian Brunner <c.m.brunner@xxxxxxxxx> wrote: > Hi Stefan, > > thanks for your feedback. Yehuda and Sage have already committed some > pathes to our git repository. > > What I'm not sure about is the rados_(de)initialization for multiple > rbd images. I suspect that _deinitialize should only be called for the > last rbd image. > > Yehuda and Sage know librados a lot better than me. I pretty sure, > that they will give some feedback about this remaining issue. After > that we will send an updated patch. > > Regards, > Christian > > 2010/11/11 Stefan Hajnoczi <stefanha@xxxxxxxxx>: >> On Fri, Oct 15, 2010 at 8:54 PM, Christian Brunner <chb@xxxxxx> wrote: >>> [...] >>> + >>> + if ((r = rados_initialize(0, NULL)) < 0) { >>> + error_report("error initializing"); >>> + return r; >>> + } >> >> Does rados_initialize() work when called multiple times? This would happen if >> the VM has several rbd devices attached. >> >> [...] >> >> Stefan >> -- >> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > The rados (de)initialization is refcounted and it is safe to call it multiple times. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html