On Thu, Nov 11, 2010 at 06:07:53PM +0200, Gleb Natapov wrote: > On Thu, Nov 11, 2010 at 05:05:11PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote: > > > On 11/10/10 18:34, Michael S. Tsirkin wrote: > > > >On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > > > >> > > > >>Signed-off-by: Gleb Natapov<gleb@xxxxxxxxxx> > > > > > > > >Good stuff. We should also consider using this for > > > >CLI and monitor. Some comments below. > > > > > > Oh, we already have a table to map pci classes to descriptions for > > > 'info pci'. > > > > You remind me, that one must be fixed to use names from > > pci_ids.h > > > For now I used numbers like other elements of the table. Fair enough. > If I > would do the conversion I would use convenience marcros to not have > names like PCI_CLASS_NETWORK_TOKEN_RING all over the table :) > > -- > Gleb. I'd prefer to keep it simple :) -- MST -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html