extraneous allocation in qemu-kvm's hw/pc_piix.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



While doing some source review I noticed what appears to be
an extraneous call to pc_allocate_cpu_irq() in qemu-kvm and
which does not appear in qemu.  From the git history it almost
looks like b725a661eb38c93086e0b98f626a3864ae8651b8 mis-merged
845773ab03a8dde681ff1b929bbb41e67d0131a6?  At any rate qemu-kvm got
patched differently than qemu for the piix split out and this line
appears to allocate something which then goes unused.

Signed-off-by: Tim Pepper <lnxninja@xxxxxxxxxxxxxxxxxx>

---

diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 3d07ce5..781d5ad 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -128,7 +128,6 @@ static void pc_init1(ram_addr_t ram_size,
     isa_bus_irqs(isa_irq);
 
     pc_register_ferr_irq(isa_reserve_irq(13));
-    cpu_irq = pc_allocate_cpu_irq();
 
     pc_vga_init(pci_enabled? pci_bus: NULL);

-- 
Tim Pepper  <lnxninja@xxxxxxxxxxxxxxxxxx>
IBM Linux Technology Center
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux