Re: [PATCH] kvm: get rid of srcu idx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 25, 2010 at 11:52:29AM -0200, Marcelo Tosatti wrote:
> On Sun, Oct 24, 2010 at 07:16:10PM +0200, Michael S. Tsirkin wrote:
> > srcu_idx is easy to misuse as it can not be used
> > in nested srcu_read_lock calls.  Switch to local
> > index to make correctness easier to verify.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > 
> > ---
> 
> Looks good to me.
> 
> Not needed for -stable, i don't see a problem with the current
> code?

It's just that I can not convince myself current code never nestes
read_locks with srcu_idx.  I used to see host crashes under migration
stress they seem gone now but did not retest - could be just luck.

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux