Avi Kivity <avi@xxxxxxxxxx> wrote: > +static void ioport_writeb_thunk(void *opaque, uint32_t addr, uint32_t data) > +{ > + IOPort *ioport = opaque; > + > + return ioport->ops->writeb(ioport, addr, data); > +} > + > +static void ioport_writew_thunk(void *opaque, uint32_t addr, uint32_t data) > +{ > + IOPort *ioport = opaque; > + > + return ioport->ops->writew(ioport, addr, data); > +} > + > +static void ioport_writel_thunk(void *opaque, uint32_t addr, uint32_t data) > +{ > + IOPort *ioport = opaque; > + > + return ioport->ops->writel(ioport, addr, data); > +} "return" is not needed on this three functions. Rest of aproach looks good. Later, Juan. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html