Re: [patch 3/3] KVM: propagate fault r/w information to gup(), allow read-only mappings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 On 10/19/2010 06:26 PM, Marcelo Tosatti wrote:
As suggested by Andrea, pass r/w error code to gup(), upgrading read fault
to writable if host pte allows it.


Looks good.


  static pfn_t hva_to_pfn(struct kvm *kvm, unsigned long addr, bool atomic,
-			bool *async)
+			bool *async, bool write_fault, bool *writable)

These sort of changes make reading the callers impossible, lots of true/false and NULL parameters which we have no idea what they mean.

We should (later) change the functions to accept a structure with named fields for these parameters instead.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux