Am 18.10.2010 15:04, Marcelo Tosatti wrote:
> On Thu, Oct 14, 2010 at 02:43:51PM +0200, Jan Kiszka wrote:
>> Am 14.10.2010 13:59, Jan Kiszka wrote:
>>> Breaks otherwise if CONFIG_IOMMU_API is not set.
>>
>> Actually, it only broke a special local version. It doesn't break with
>> current KVM due to
>>
>> [__kvm_set_memory_region:]
>> #ifdef CONFIG_DMAR
>> /* map the pages in iommu page table */
>> if (npages) {
>> r = kvm_iommu_map_pages(kvm, &new);
>> if (r)
>> goto out_free;
>> }
>> #endif
>>
>> And CONFIG_IOMMU_API is set when CONFIG_DMAR is enabled. But do we only
>> need this call on Intel?
>
> On CONFIG_AMD_IOMMU too. It should be conditional on CONFIG_IOMMU_API.
>
Then we can simply drop the #ifdef here as kvm_iommu_map_pages is
stubbed for !CONFIG_IOMMU_API.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
