On Sun, Oct 17, 2010, Avi Kivity wrote about "Re: [PATCH 10/27] nVMX: Implement VMCLEAR": > >+ vmcs12 = kmap(page); > > kmap_atomic() please (better, kvm_write_guest(), but can defer that for > later) Sorry about my ignorance, but why is kmap_atomic() better here than kmap()? While handling an exit (caused by a guest running VMCLEAR instruction), we aren't in atomic context, aren't we? If I use kmap_atomic() here I'll need to kunmap_atomic() below which will break the newly combined kunmap & nested_release_page function ;-) > >+ vmcs12->launch_state = 0; > >+ kunmap(page); > >+ nested_release_page(page); -- Nadav Har'El | Sunday, Oct 17 2010, 9 Heshvan 5771 nyh@xxxxxxxxxxxxxxxxxxx |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |Diplomat: A man who always remembers a http://nadav.harel.org.il |woman's birthday but never her age. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
