On Sun, Oct 17, 2010, Avi Kivity wrote about "Re: [PATCH 05/27] nVMX: Introduce vmcs12: a VMCS structure for L1":
> >+ if(to_vmx(vcpu)->nested.current_vmptr != -1ull){
>
> Missing whitespace after if and before {.
Sorry about that - I forgot to run checkpatch.pl on this iteration.
I now fixed this, and a bunch of other small style issues.
> > }
> >@@ -4170,6 +4229,10 @@ static void vmx_free_vcpu(struct kvm_vcp
> > struct vcpu_vmx *vmx = to_vmx(vcpu);
> >
> > free_vpid(vmx);
> >+ if (vmx->nested.vmxon&& to_vmx(vcpu)->nested.current_vmptr !=
> >-1ull){
> >+ kunmap(to_vmx(vcpu)->nested.current_vmcs12_page);
> >+ nested_release_page(to_vmx(vcpu)->nested.current_vmcs12_page);
> >+ }
>
> Duplication - helper?
Ok, I just moved the kunmap() into nested_release_page() - it was always
called before nested_release_page. I hope that's what you meant by
"duplication".
--
Nadav Har'El | Sunday, Oct 17 2010, 9 Heshvan 5771
nyh@xxxxxxxxxxxxxxxxxxx |-----------------------------------------
Phone +972-523-790466, ICQ 13349191 |Unix is user friendly - it's just picky
http://nadav.harel.org.il |about its friends.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
