Hi Kevin,
On Tue, Oct 12, 2010 at 09:11, Kevin O'Connor <kevin@xxxxxxxxxxxx> wrote:
> On Tue, Oct 12, 2010 at 08:49:58AM +0200, Avi Kivity wrote:
>> ÂOn 10/11/2010 07:53 PM, Ruben Kerkhof wrote:
>> >5c99b6c984682ddb1d4543a7e27a1f4ca633e6a6 is the first bad commit
>> >commit 5c99b6c984682ddb1d4543a7e27a1f4ca633e6a6
>> >Author: Kevin O'Connor<kevin@xxxxxxxxxxxx>
>> Gleb, Kevin, any ideas?
>>
>> (summary: qemu-kvm doesn't acpi shutdown freebsd 8.1 with this
>> commit; qemu.git does. ÂMay be due to interrupt polarity which kvm
>> implements but qemu does not)
>
> The only thing in commit 5c99b6c9 that could cause an issue is that it
> has the compiled acpi changes actually made in commit 29f4b912, but I
> don't see how that would be a problem to reboots:
>
> diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl
> index cee038a..2bede25 100644
> --- a/src/acpi-dsdt.dsl
> +++ b/src/acpi-dsdt.dsl
> @@ -58,7 +58,10 @@ DefinitionBlock (
> Â#define prt_slot2(nr) prt_slot(nr, LNKB, LNKC, LNKD, LNKA)
> Â#define prt_slot3(nr) prt_slot(nr, LNKC, LNKD, LNKA, LNKB)
> Â Â Â Â Â Â Â Âprt_slot0(0x0000),
> - Â Â Â Â Â Â Â prt_slot1(0x0001),
> + Â Â Â Â Â Â Â Package() { 0x0001ffff, 0, 0, 9 },
> + Â Â Â Â Â Â Â Package() { 0x0001ffff, 1, LNKB, 0 },
> + Â Â Â Â Â Â Â Package() { 0x0001ffff, 2, LNKC, 0 },
> + Â Â Â Â Â Â Â Package() { 0x0001ffff, 3, LNKD, 0 },
> Â Â Â Â Â Â Â Âprt_slot2(0x0002),
> Â Â Â Â Â Â Â Âprt_slot3(0x0003),
> Â Â Â Â Â Â Â Âprt_slot0(0x0004),
>
> Can you confirm that commit 4c94b7ea works reliably while commit
> 5c99b6c9 does not?
>
> -Kevin
>
Yes, that's correct.
Is there anything I can do to help resolve this?
Would rolling back this commit have any impact on other operating systems?
Regards,
Ruben
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
