On Tue, Oct 12, 2010 at 02:49:58PM +0800, Sheng Yang wrote: > On Monday 11 October 2010 18:01:00 Michael S. Tsirkin wrote: > > On Mon, Oct 11, 2010 at 05:28:30PM +0800, Sheng Yang wrote: > > > On Sunday 03 October 2010 19:12:47 Michael S. Tsirkin wrote: > > > > On Tue, Sep 28, 2010 at 05:44:10PM +0800, Sheng Yang wrote: > > > > > This patch enable per-vector mask for assigned devices using MSI-X. > > > > > > > > > > Signed-off-by: Sheng Yang <sheng@xxxxxxxxxxxxxxx> > > > > > > > > I think I see an issue here, noted below. Some general comments: > > > > - The mask bit seems broken for injecting interrupts from > > > > > > > > userspace (with interrupts/ioctls). > > > > I think we must test it on injection path. > > > > > > I am not quite understand how it related to userspace interrupt injection > > > here... This patch only cover assigned devices for now. > > > > Well, this is a kernel/userspace interface, if it's broken for userspace > > injection now we'll have to go through pain to fix it in a compatible > > way later when we want to use it for userspace injection. > > You might want to ask why we want the kernel to support making > > userspace-injected interrupts when userspace can just avoid injecting > > them, and the answer would be that with irqfd the injection might be > > handled in a separate process. > > OK, I've understood how it related to userspace interrupt injection. But I still > can't see why the interface is broken... That's easy to explain: mask vector, then inject interrupt with an ioctl or irqfd: it still goes in even though it's masked. -- MST -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
