Re: [PATCH 1/1] virtio_console: perf-test fix [FIX] read-out all data after perf-test [FIX] code clean-up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- "Amit Shah" <amit.shah@xxxxxxxxxx> wrote:

> On (Thu) Sep 23 2010 [14:11:52], Lukas Doktor wrote:
> > @@ -829,6 +832,11 @@ def run_virtio_console(test, params, env):
> >              exit_event.set()
> >              thread.join()
> >  
> > +            # Let the guest read-out all the remaining data
> > +            while not _on_guest("virt.poll('%s', %s)"
> > +                                    % (port[1], select.POLLIN), vm,
> 2)[0]:
> > +                time.sleep(1)
> 
> This is just polling the guest, not reading out any data?

The reading thread in on guest side. We are only check when stop
guest side reading thread.

> 
> (BTW POLLIN will be set if host is disconnected and there's no data
> to
> read, so ensure you don't enter an infinite loop here.)
> 
> 		Amit
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux