On 09/27/2010 10:30 PM, Avi Kivity wrote: >> r = FNAME(walk_addr)(&walker, vcpu, vaddr, >> - !!(access& PFERR_WRITE_MASK), >> - !!(access& PFERR_USER_MASK), >> - !!(access& PFERR_FETCH_MASK)); >> + access& PFERR_WRITE_MASK, >> + access& PFERR_USER_MASK, >> + access& PFERR_FETCH_MASK); >> >> if (r) { >> gpa = gfn_to_gpa(walker.gfn); > > Interesting. Maybe a next step is to pass the page-fault error code > instead of the various bits? Yeah, it's a good idea, i'll post a patch to do it. > Not sure how that interacts with nested > ept (which has a different permission model). > Umm, we just move the error code parsing from the caller site to FNAME(walk_addr) function, i think it not make trouble for implement nested ept. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html