On Mon, Sep 27, 2010 at 11:02:23AM -0400, Avi Kivity wrote: > On 09/27/2010 04:58 PM, Avi Kivity wrote: > > On 09/27/2010 03:16 PM, Joerg Roedel wrote: > >> This patch adds the svm cpuid feature flags to the qemu > >> intialization path. It also adds the svm features available > >> on phenom to its cpu-definition and extends the host cpu > >> type to support all svm features KVM can provide. > >> > > > > This should really be "all svm features" since we'll later mask them > > with kvm capabilities. This way, if we later add more capabilities, > > we automatically gain support in userspace. Yes, that is what -cpu host does with these patches applied. The svm_features variable is set to -1 in this case and masked out later with the KVM capabilities. > > > > (or rather, all svm features that don't need save/restore support in > > userspace; I don't think any do, beyond svm itself) > > > > I applied 2 and 3 (to branch uq/master). If you want to add more svm > features, please send a patch. For patch 1, I'd like a review by > someone who understands the compat code. Great, thanks. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
