On Sun, Sep 26, 2010, Avi Kivity wrote about "Re: [PATCH 16/24] Implement VMLAUNCH and VMRESUME": > I don't see how vcpu->arch.cr0 can cache cr0_read_shadow. But this is precisely what the (unpatched) vmx_set_cr0 code does: If you look at it, it takes a parameter "cr0" and builds an additional variable "hw_cr0". "cr0" gets written into CR0_READ_SHADOW, while "hw_cr0" gets written into GUEST_CR0. vcpu->arch.cr0 gets a copy of "cr0", not of "hw_cr0", i.e., it is a cache of CR0_READ_SHADOW, not of GUEST_CR0. Or am I missing something? Thanks, Nadav. -- Nadav Har'El | Sunday, Sep 26 2010, 18 Tishri 5771 nyh@xxxxxxxxxxxxxxxxxxx |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |What's the greatest world-wide use of http://nadav.harel.org.il |cowhide? To hold cows together. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
