On Tue, Sep 21, 2010 at 06:05:10PM +0200, Avi Kivity wrote: > On 09/20/2010 07:02 PM, Michael S. Tsirkin wrote: > >On Mon, Sep 20, 2010 at 05:06:41PM +0200, Avi Kivity wrote: > >> This cleans up msix/kvm integration a bit. The really important patch is the > >> last one, which allows msix.o to be part of non-target-specific build. > > > >I actually thoought this later move should be done in a different way: > >- add all functions msix uses to kvm-stub.c > > Isn't that what I did? > > >- kvm_irq_routing_entry should also have a stub > > > >I sent some minor comments in case you have a reason > >to prefer this way. > > My motivation is really the last patch. If you explain what you'd > like to see I'll try to do it. Basically my idea was to avoid all ifdefs in msix.c *without changing it*, by stubbing out kvm APIs and structures we use there. -- MST -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html