On Sun, Sep 19, 2010 at 07:50:27PM +0200, Gleb Natapov wrote: > On Sun, Sep 19, 2010 at 07:29:41PM +0200, Joerg Roedel wrote: > > On Sun, Sep 19, 2010 at 06:41:27PM +0200, Gleb Natapov wrote: > > > Nested SVM checks for external interrupt after injecting nested exception. > > > In case there is external interrupt pending the code generates "external > > > interrupt exit" and overwrites previous exit info. If previously injected > > > exception already generated exit it will be lost. > > > > Right. Have you seen specific mismehavior due to this problem? I am just > > curious how you found this :-) > Yes. Trying to make async page fault work with nested svm :) It was hard > to fix with reproducible test case. I am not dreaming to fix it just by > code review. Interesting. Hope this was the only problem and you have it working now? > > And another question, can you put the reason for this "if(...) return" > > into an comment before the statement? The whole svm-emulation thing is > > complicated enough so that we should document it well in the code :-) > > > Complicated is understatement. Will add a comment. Thanks, the most complicated thing is to get all the interrupt- exception- and event-reinjection thing right. You just fixed another bug there, thanks again :) Joerg -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
