Re: [PATCH] device-assignment: register a reset function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 14, 2010 at 9:04 AM, Bernhard Kohl <bernhard.kohl@xxxxxxx> wrote:
> This is necessary because during reboot of a VM the assigned devices
> continue DMA transfers which causes memory corruption.
>
> Signed-off-by: Thomas Ostler <thomas.ostler@xxxxxxx>
> Signed-off-by: Bernhard Kohl <bernhard.kohl@xxxxxxx>
> ---
>  hw/device-assignment.c |   14 ++++++++++++++
>  1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index 87f7418..001aee8 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -1450,6 +1450,17 @@ static void assigned_dev_unregister_msix_mmio(AssignedDevice *dev)
>     dev->msix_table_page = NULL;
>  }
>
> +static void reset_assigned_device(void *opaque)
> +{
> +    PCIDevice *d = (PCIDevice *)opaque;
> +    uint32_t conf;
> +
> +    /* reset the bus master bit to avoid further DMA transfers */
> +    conf = assigned_dev_pci_read_config(d, 0x04, 0x02);
> +    conf &= ~0x04;
> +    assigned_dev_pci_write_config(d, 0x04, conf, 0x02);

This should use defined macros, PCI_COMMAND & PCI_COMMAND_MASTER.
Otherwise seems ok.  Thanks,

Alex

> +}
> +
>  static int assigned_initfn(struct PCIDevice *pci_dev)
>  {
>     AssignedDevice *dev = DO_UPCAST(AssignedDevice, dev, pci_dev);
> @@ -1499,6 +1510,9 @@ static int assigned_initfn(struct PCIDevice *pci_dev)
>     if (r < 0)
>         goto assigned_out;
>
> +    /* register reset function for the device */
> +    qemu_register_reset(reset_assigned_device, pci_dev);
> +
>     /* intercept MSI-X entry page in the MMIO */
>     if (dev->cap.available & ASSIGNED_DEVICE_CAP_MSIX)
>         if (assigned_dev_register_msix_mmio(dev))
> --
> 1.7.2.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux