On Tue, Sep 07, 2010 at 02:43:16PM -0400, Marcelo Tosatti wrote: > On Mon, Sep 06, 2010 at 05:55:58PM +0200, Joerg Roedel wrote: > > r = x86_decode_insn(&vcpu->arch.emulate_ctxt); > > + if (r == X86EMUL_PROPAGATE_FAULT) > > + goto done; > > + > > x86_decode_insn returns -1 / 0 ? Yes. This looks like a left-over from v2 of the patch-set. I'll check the path again and remove it if not necessary anymore. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html