On 09/06/2010 03:05 PM, Andre Przywara wrote:
Did we really enable "sse5" before xsave? That looks broken, but I
guess no real harm if xsave itself is not enabled.
Yes. It somehow slipped through when you introduced the other feature
flags to KVM. I also think this is not a serious problem.
BTW: I realized that AES is currently denied. Reading the manual I see
that it operates on SSE registers, so it should be safe to be passed
through. The only drawback is that it would change the visible CPUID
on CPUs that already have AES, whereas earlier KVM versions did hide it.
This code doesn't directly affect a guest's cpuid, it merely tells host
userspace which cpuid bits are supported by kvm. It's perfectly fine to
add bits as we add support, in fact this interface is what makes
migration work across cpus with different capabilities.
This could become a problem with migration. But if you agree, I'd
integrate this flag in the v2 series.
Shouldn't be a problem - please do.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
