Re: [PATCH 3/3] KVM: x86 emulator: trap and propagate #DE from DIV and IDIV

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 On 08/26/2010 12:05 AM, Marcelo Tosatti wrote:

@@ -3363,7 +3374,7 @@ special_insn:
  		break;
  	case 0xf6 ... 0xf7:	/* Grp3 */
  		if (emulate_grp3(ctxt, ops) != X86EMUL_CONTINUE)
-			goto cannot_emulate;
+			goto done;
  		break;
Must assign rc to emulate_grp3() retval.

While there's not much difference between X86EMUL_PROPAGATE_FAULT and X86EMUL_CONTINUE, it's bad form to break things internally. I'll fix and repost.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux