Re: [PATCH 2/8] KVM: x86 emulator: simplify ALU block (opcodes 00-3F) decode flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 23, 2010 at 02:06:11PM +0300, Avi Kivity wrote:
> Use the new byte/word dual opcode decode.
> 
> Signed-off-by: Avi Kivity <avi@xxxxxxxxxx>
> ---
>  arch/x86/kvm/emulate.c |   40 ++++++++++++++++------------------------
>  1 files changed, 16 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 152654e..79a5f81 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -2370,42 +2370,34 @@ static struct group_dual group9 = { {
>  
>  static struct opcode opcode_table[256] = {
>  	/* 0x00 - 0x07 */
> -	D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> -	D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> -	D(ByteOp | DstAcc | SrcImm), D(DstAcc | SrcImm),
> +	D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> +	D2bv(DstAcc | SrcImm),
>  	D(ImplicitOps | Stack | No64), D(ImplicitOps | Stack | No64),
>  	/* 0x08 - 0x0F */
> -	D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> -	D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> -	D(ByteOp | DstAcc | SrcImm), D(DstAcc | SrcImm),
> +	D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> +	D2bv(DstAcc | SrcImm),
>  	D(ImplicitOps | Stack | No64), N,
>  	/* 0x10 - 0x17 */
> -	D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> -	D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> -	D(ByteOp | DstAcc | SrcImm), D(DstAcc | SrcImm),
> +	D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> +	D2bv(DstAcc | SrcImm),
>  	D(ImplicitOps | Stack | No64), D(ImplicitOps | Stack | No64),
>  	/* 0x18 - 0x1F */
> -	D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> -	D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> -	D(ByteOp | DstAcc | SrcImm), D(DstAcc | SrcImm),
> +	D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> +	D2bv(DstAcc | SrcImm),
>  	D(ImplicitOps | Stack | No64), D(ImplicitOps | Stack | No64),
>  	/* 0x20 - 0x27 */
> -	D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> -	D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> -	D(ByteOp | DstAcc | SrcImmByte), D(DstAcc | SrcImm), N, N,
> +	D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> +	D2bv(DstAcc | SrcImmByte), N, N,

SrcImm? opcode 0x25...

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux