On Tue, Aug 24, 2010 at 05:01:10PM +0300, Avi Kivity wrote: > On 08/24/2010 04:52 PM, Gleb Natapov wrote: > > > >We can, of course. But for me it looks as arbitrary as -1/0/1 since not > >all enum values have meanings to the caller. > > Yeah. -1/0/1's problem is that between reading the callee code and > caller code, I manage to forget what the values mean. > Luckily we have only one caller of x86_emulate_insn(), so documenting return values right where function is called should help. :) -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
