RE: [PATCH] Fix bug for vcpu hotplug

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Avi Kivity wrote:
>   On 08/06/2010 06:36 AM, Liu, Jinsong wrote:
>> Recently seabios implement vcpu hotplug infrastructure.
>> During test, we found qemu-kvm has a bug result in guestos shutdown
>> when vcpu hotadd. This patch is to fix the bug, mark
>> bus->allow_hotplug as 1 after qdev_hotplug init done. 
> 
> Please copy qemu-devel on qemu patches.
> 
>> @@ -117,6 +117,9 @@ DeviceState *qdev_create(BusState *bus, const
>>           char *name) hw_error("Unknown device '%s' for bus '%s'\n",
>> name, bus->info->name);       } 
>> 
>> +    if (qdev_hotplug)
>> +        bus->allow_hotplug = 1;
>> +
>>       return qdev_create_from_info(bus, info);
>>   }
> 
> Doesn't seem right - this will set allow_hotplug on all busses.
> 
> It needs to be set only on the system bus (hw/sysbus.c).


Thanks Avi for comments!
We update the patch to fix the bug in a simple way, your opinion?


Thanks,
Jinsong

Attachment: fix-vcpu-hotplug.patch
Description: fix-vcpu-hotplug.patch