On 08/14/2010 03:19 AM, Mohammed Gamal wrote:
emulate_int_real() is to be used outside the emulator. Hence, we shouldn't wait for writeback to write the eip value stored in the decode cache. Save it in emulation context eagerly instead. Signed-off-by: Mohammed Gamal<m.gamal005@xxxxxxxxx> --- arch/x86/kvm/emulate.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 32498e3..ae45b04 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -1245,7 +1245,7 @@ int emulate_int_real(struct x86_emulate_ctxt *ctxt, if (rc != X86EMUL_CONTINUE) return rc; - c->eip = eip; + ctxt->eip = eip; return rc; }
Doesn't seem right. It should work like the rest of the emulator. Instead, the wrapper code in x86.c should do this. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html