Re: [PATCH 15/15] KVM: x86 emulator: Decode memory operands directly into a 'struct operand'

[Paolo Bonzini <pbonzini@xxxxxxxxxx>]

On 08/01/2010 04:23 PM, Avi Kivity wrote:
>   	if (c->src.type == OP_MEM) {
> +		if (c->d & NoAccess)
> +			goto no_fetch;
>   		rc = read_emulated(ctxt, ops, c->src.addr.mem,
>   					c->src.valptr, c->src.bytes);
>   		if (rc != X86EMUL_CONTINUE)
>   			goto done;
>   		c->src.orig_val = c->src.val;
> +	no_fetch:
> +		;
>   	}

Maybe remove the goto?

	if (c->src.type == OP_MEM && !(c->d & NoAccess)) {
		rc = read_emulated(ctxt, ops, c->src.addr.mem,
				   c->src.valptr, c->src.bytes);
		if (rc != X86EMUL_CONTINUE)
			goto done;
		c->src.orig_val = c->src.val;
	}

Or do you have other plans for it? :)

Thanks,

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html