Re: [PATCH] increase MAX_NICS value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-07-09 at 12:30 -0500, Brian Jackson wrote:
> On Friday, July 09, 2010 10:39:17 am Alessandro Bono wrote:
> > Hi all
> > 
> > max number of allowed nics per vm is hardcoded on net.h to 8. This value
> > it's too low in situation with big network, increase to 24
> > this should be safe as mentioned on this thread
> > http://kerneltrap.org/mailarchive/linux-kvm/2009/1/29/4848304/thread
> 
> 
> A better long term solution might be to convert it to QLIST or something 
> instead of hardcoding the array size.

Sure my patch it's simply a better default value and solve the problem
for big network. Obviously a dynamic structure it's best suited for this
information

> 
> 
> > 
> > Signed-off-by: Alessandro Bono <alessandro.bono@xxxxxxxxx>
> > 
> > --- net.h.old   2010-07-09 17:30:39.542170103 +0200
> > +++ net.h       2010-07-09 17:30:48.842166029 +0200
> > @@ -121,7 +121,7 @@
> > 
> >  /* NIC info */
> > 
> > -#define MAX_NICS 8
> > +#define MAX_NICS 24
> > 
> >  struct NICInfo {
> >      uint8_t macaddr[6];

-- 
Cordiali Saluti
Alessandro Bono

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux