Re: [PATCH v4 08/12] Inject asynchronous page fault into a guest if page is swapped out.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2010-07-08 at 21:05 +0300, Gleb Natapov wrote:
> > > +   /* do alloc atomic since if we are going to sleep anyway we
> > > +      may as well sleep faulting in page */
> > > +   work = kmem_cache_zalloc(async_pf_cache, GFP_ATOMIC);
> > > +   if (!work)
> > > +           return 0;
> > 
> > GFP_KERNEL is fine for this context.
> But it can sleep, no? The comment explains why I don't want to sleep
> here. 

In that case, use 0, no use wasting __GFP_HIGH on something that doesn't
actually need it.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux