Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(2010/06/27 16:32), Avi Kivity wrote:
On 06/25/2010 10:25 PM, Alexander Graf wrote:
On 23.06.2010, at 08:01, Takuya Yoshikawa wrote:

kvm_get_dirty_log() is a helper function for
kvm_vm_ioctl_get_dirty_log() which
is currently used by ia64 and ppc and the following is what it is doing:

- sanity checks
- bitmap scan to check if the slot is dirty
- copy_to_user()

Considering the fact that x86 is not using this anymore and sanity
checks must
be done before kvm_ia64_sync_dirty_log(), we can say that this is not
working
for code sharing effectively. So we just remove this.
This patch plus 4/4 broke dirty bitmap updating on PPC. I didn't get
around to track down why, but I figured you should now. Is there any
way to get you a PPC development box? A simple G4 or G5 should be 200$
on ebay by now :).

Best to revert these patches and re-apply when fixed.


Please revert. Sincerely sorry.

I'll fix as soon as possible and re-submit when test on PPC gets OK.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux