On 3/18/25 15:19, Richard Henderson wrote:
On 3/17/25 21:51, Pierrick Bouvier wrote:
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index f89568bfa39..28de3990699 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -13,6 +13,10 @@
*
*/
+#ifdef TARGET_AARCH64
+#define KVM_HAVE_MCE_INJECTION 1
+#endif
+
#include "qemu/osdep.h"
#include <sys/ioctl.h>
#include <poll.h>
I think this define should go after all #includes, emphasizing that it only affects this file.
I think the #ifdef should use __aarch64__. KVM is explicitly only for the host, so
TARGET_AARCH64 really means the host is also AArch64.
I think you should go ahead and adjust x86_64 either with the same patch or immediately
afterward. There are only two users after all.
I'll adjust this for x86_64 in the same patch.
r~
