On 3/17/25 08:50, Philippe Mathieu-Daudé wrote:
On 14/3/25 18:31, Pierrick Bouvier wrote:Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxx> --- include/exec/ram_addr.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h index f5d574261a3..92e8708af76 100644 --- a/include/exec/ram_addr.h +++ b/include/exec/ram_addr.h @@ -339,7 +339,9 @@ static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, } }- xen_hvm_modified_memory(start, length);+ if (xen_enabled()) { + xen_hvm_modified_memory(start, length);Please remove the stub altogether.
We can eventually ifdef this code under CONFIG_XEN, but it may still be available or not. The matching stub for xen_hvm_modified_memory() will assert in case it is reached.
Which change would you expect precisely?
+ } }
