On Mon, 2010-06-21 at 15:37 +0300, Avi Kivity wrote: > On 06/21/2010 12:31 PM, Zhang, Yanmin wrote: > > The 5th patch is applied to the latest qemu-kvm tree. > > > > --- qemu-kvm_0621/target-i386/kvm.c 2010-06-21 11:00:29.000000000 +0800 > > +++ qemu-kvm_0621_perf/target-i386/kvm.c 2010-06-21 13:00:14.136999850 +0800 > > @@ -150,6 +150,9 @@ struct kvm_para_features { > > #ifdef KVM_CAP_PV_MMU > > { KVM_CAP_PV_MMU, KVM_FEATURE_MMU_OP }, > > #endif > > +#ifdef KVM_CAP_PV_PERF > > + { KVM_CAP_PV_PERF, KVM_FEATURE_PV_PERF }, > > +#endif > > { -1, -1 } > > }; > > > > > > > Not really necessary any more - if you expose the cpuid bit via > KVM_GET_SUPPORTED_CPUID2 then 'qemu -cpu host' will automatically enable it. > > On the other hand, do update target-i386/cpuid.c:kvm_feature_name so > people can enable the feature using qemu -cpu ...,+kvmperf. Thanks for the good pointer. I will change it. Avi, Thanks for your wonderful comments. I will fix all in the patches. As for the live migration, I need check it carefully. If you could provide some suggestions on it, especially about how/when to save all perf_events and restore all pref_events, that would be very helpful. Yanmin -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html