Re: [PATCH 01/14] hw/vfio/common: Include missing 'system/tcg.h' header

Cédric Le Goater <clg@xxxxxxxxxx> · Sat, 8 Mar 2025 18:39:11 +0100

On 3/7/25 19:03, Philippe Mathieu-Daudé wrote:
Always include necessary headers explicitly, to avoid
when refactoring unrelated ones:

   hw/vfio/common.c:1176:45: error: implicit declaration of function ‘tcg_enabled’;
    1176 |                                             tcg_enabled() ? DIRTY_CLIENTS_ALL :
         |                                             ^~~~~~~~~~~

Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>


Reviewed-by: Cédric Le Goater <clg@xxxxxxxxxx>

Thanks,

C.


---
  hw/vfio/common.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 7a4010ef4ee..b1596b6bf64 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -42,6 +42,7 @@
  #include "migration/misc.h"
  #include "migration/blocker.h"
  #include "migration/qemu-file.h"
+#include "system/tcg.h"
  #include "system/tpm.h"
  
  VFIODeviceList vfio_device_list =








