Hi Zhao, On 3/5/25 6:46 AM, Zhao Liu wrote: > On Sun, Mar 02, 2025 at 02:00:11PM -0800, Dongli Zhang wrote: >> Date: Sun, 2 Mar 2025 14:00:11 -0800 >> From: Dongli Zhang <dongli.zhang@xxxxxxxxxx> >> Subject: [PATCH v2 03/10] [DO NOT MERGE] kvm: Introduce >> kvm_arch_pre_create_vcpu() >> X-Mailer: git-send-email 2.43.5 >> >> From: Xiaoyao Li <xiaoyao.li@xxxxxxxxx> >> >> Introduce kvm_arch_pre_create_vcpu(), to perform arch-dependent >> work prior to create any vcpu. This is for i386 TDX because it needs >> call TDX_INIT_VM before creating any vcpu. >> >> The specific implemnet of i386 will be added in the future patch. >> >> Signed-off-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx> >> Acked-by: Gerd Hoffmann <kraxel@xxxxxxxxxx> > > Your Signed-off is missing... > > (When you send the patch, it's better to attach your own Signed-off :-)) Thank you very much! I didn't know if I would need to wait until this patch is merged into mainline QEMU. That's why I didn't add my signed-off. I will add in v3 and remove "DO NOT MERGE" if the patch isn't in QEMU when I am sending out v3. Dongli Zhang > >> --- >> I used to send a version: >> https://urldefense.com/v3/__https://lore.kernel.org/all/20221119122901.2469-2-dongli.zhang@xxxxxxxxxx/__;!!ACWV5N9M2RV99hQ!P5Ki_gsFsvAUNjV4-CNmMcDAJA5QRyzJ5ufGtNqeH6Ayt2ZUxwoPde3VQVer_o9Y2xRSVTwCN5fdjO-Dyerp$ >> Just pick the one from Xiaoyao's patchset as Dapeng may use this version >> as well. >> https://urldefense.com/v3/__https://lore.kernel.org/all/20250124132048.3229049-8-xiaoyao.li@xxxxxxxxx/__;!!ACWV5N9M2RV99hQ!P5Ki_gsFsvAUNjV4-CNmMcDAJA5QRyzJ5ufGtNqeH6Ayt2ZUxwoPde3VQVer_o9Y2xRSVTwCN5fdjN17lCxG$ >> >> accel/kvm/kvm-all.c | 5 +++++ >> include/system/kvm.h | 1 + >> target/arm/kvm.c | 5 +++++ >> target/i386/kvm/kvm.c | 5 +++++ >> target/loongarch/kvm/kvm.c | 5 +++++ >> target/mips/kvm.c | 5 +++++ >> target/ppc/kvm.c | 5 +++++ >> target/riscv/kvm/kvm-cpu.c | 5 +++++ >> target/s390x/kvm/kvm.c | 5 +++++ >> 9 files changed, 41 insertions(+) > > Reviewed-by: Zhao Liu <zhao1.liu@xxxxxxxxx> >
