Re: [PATCH v2 04/10] target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Xiaoyao Li <xiaoyao.li@xxxxxxxxx>
Subject: Re: [PATCH v2 04/10] target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured
From: Zhao Liu <zhao1.liu@xxxxxxxxx>
Date: Wed, 5 Mar 2025 22:41:47 +0800
Cc: Dongli Zhang <dongli.zhang@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, pbonzini@xxxxxxxxxx, mtosatti@xxxxxxxxxx, sandipan.das@xxxxxxx, babu.moger@xxxxxxx, likexu@xxxxxxxxxxx, like.xu.linux@xxxxxxxxx, zhenyuw@xxxxxxxxxxxxxxx, groug@xxxxxxxx, khorenko@xxxxxxxxxxxxx, alexander.ivanov@xxxxxxxxxxxxx, den@xxxxxxxxxxxxx, davydov-max@xxxxxxxxxxxxxx, dapeng1.mi@xxxxxxxxxxxxxxx, joe.jin@xxxxxxxxxx
In-reply-to: <76da2b4a-2dc4-417c-91bc-ad29e08c8ba0@intel.com>
References: <20250302220112.17653-1-dongli.zhang@oracle.com> <20250302220112.17653-5-dongli.zhang@oracle.com> <76da2b4a-2dc4-417c-91bc-ad29e08c8ba0@intel.com>

> > +        if (has_pmu_cap && !X86_CPU(cpu)->enable_pmu) {
> 
> One nit, it's safer to use
> 
> 	(has_pmu_cap & KVM_PMU_CAP_DISABLE) && !X86_CPU(cpu)->enable_pmu
> 
> Maybe we can rename has_pmu_cap to pmu_cap as well.

Yes, I agree.

Regards,
Zhao

Follow-Ups:
- Re: [PATCH v2 04/10] target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured
  - From: dongli . zhang

References:
- [PATCH v2 00/10] target/i386/kvm/pmu: PMU Enhancement, Bugfix and Cleanup
  - From: Dongli Zhang
- [PATCH v2 04/10] target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured
  - From: Dongli Zhang
- Re: [PATCH v2 04/10] target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured
  - From: Xiaoyao Li

Prev by Date: Re: [Kernel 6.12.17] [PowerPC e5500] KVM HV compilation error
Next by Date: Re: [PATCH v2 04/10] target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured
Previous by thread: Re: [PATCH v2 04/10] target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured
Next by thread: Re: [PATCH v2 04/10] target/i386/kvm: set KVM_PMU_CAP_DISABLE if "-pmu" is configured
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]