I tested this patch with virtio-net and mlx5 vdpa regression tests, everything works fine. Tested-by: Lei Yang <leiyang@xxxxxxxxxx> On Fri, Feb 21, 2025 at 9:13 AM Jason Wang <jasowang@xxxxxxxxxx> wrote: > > On Fri, Feb 21, 2025 at 3:40 AM Dragos Tatulea <dtatulea@xxxxxxxxxx> wrote: > > > > From: Si-Wei Liu <si-wei.liu@xxxxxxxxxx> > > > > create_user_mr() has correct code to count the number of null keys > > used to fill in a hole for the memory map. However, fill_indir() > > does not follow the same to cap the range up to the 1GB limit > > correspondingly. Fill in more null keys for the gaps in between, > > so that null keys are correctly populated. > > > > Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared memory registration code") > > Cc: stable@xxxxxxxxxxxxxxx > > Reported-by: Cong Meng <cong.meng@xxxxxxxxxx> > > Signed-off-by: Si-Wei Liu <si-wei.liu@xxxxxxxxxx> > > Signed-off-by: Dragos Tatulea <dtatulea@xxxxxxxxxx> > > Acked-by: Eugenio Pérez <eperezma@xxxxxxxxxx> > > Acked-by: Jason Wang <jasowang@xxxxxxxxxx> > > Thanks > >