On Fri, Feb 21, 2025 at 05:45:26PM -0800, Sean Christopherson wrote: > Convert all non-x86 #ifdefs from __ASSEMBLY__ to __ASSEMBLER__, and remove > all manual __ASSEMBLY__ #defines. __ASSEMBLY_ was inherited blindly from > the Linux kernel, and must be manually defined, e.g. through build rules > or with the aforementioned explicit #defines in assembly code. > > __ASSEMBLER__ on the other hand is automatically defined by the compiler > when preprocessing assembly, i.e. doesn't require manually #defines for > the code to function correctly. > > Ignore x86, as x86 doesn't actually rely on __ASSEMBLY__ at the moment, > and is undergoing a parallel cleanup. With ignoring x86, I see just one other instance of ASSEMBLY, which is in a comment and is mispelled to only have the leading underscores lib/libfdt/fdt.h:48:#endif /* !__ASSEMBLY */ With that replaced, for riscv and arm Reviewed-by: Andrew Jones <andrew.jones@xxxxxxxxx> Thanks, drew
