On 2/19/2025 3:21 AM, Francesco Lavra wrote:
On Fri, 24 Jan 2025 08:20:01 -0500, Xiaoyao Li wrote:
diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c
index 4ff94860815d..bd212abab865 100644
--- a/target/i386/kvm/tdx.c
+++ b/target/i386/kvm/tdx.c
@@ -10,17 +10,122 @@
*/
#include "qemu/osdep.h"
+#include "qemu/error-report.h"
+#include "qapi/error.h"
#include "qom/object_interfaces.h"
#include "hw/i386/x86.h"
#include "kvm_i386.h"
#include "tdx.h"
+static struct kvm_tdx_capabilities *tdx_caps;
Instead of a static variable, this should be a member of the TdxGuest
struct.
I don't think so.
tdx_caps is reported from KVM, which indicates what XFAM/Attributes and
configurable CPUID bits that can be configured for a TD under the KVM.
It's not the specific properties of the TD.
So I would keep it as it.
