No change in behavior observed from v1 on my config (DGX H100). Thanks! Reviewed-by: "Mitchell Augustin" <mitchell.augustin@xxxxxxxxxxxxx> Tested-by: "Mitchell Augustin" <mitchell.augustin@xxxxxxxxxxxxx> On Tue, Feb 18, 2025 at 4:46 PM Peter Xu <peterx@xxxxxxxxxx> wrote: > > On Tue, Feb 18, 2025 at 03:22:04PM -0700, Alex Williamson wrote: > > Page count should more consistently be an unsigned long when passed as > > an argument while functions returning a number of pages should use a > > signed long to allow for -errno. > > > > vaddr_get_pfns() can therefore be upgraded to return long, though in > > practice it's currently limited by the batch capacity. In fact, the > > batch indexes are noted to never hold negative values, so while it > > doesn't make sense to bloat the structure with unsigned longs in this > > case, it does make sense to specify these as unsigned. > > > > No change in behavior expected. > > > > Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx> > > Reviewed-by: Peter Xu <peterx@xxxxxxxxxx> > > -- > Peter Xu > -- Mitchell Augustin Software Engineer - Ubuntu Partner Engineering
