On Fri, 14 Feb 2025 22:39:30 +0100 David Hildenbrand <david@xxxxxxxxxx> wrote: > On 14.02.25 18:17, Alex Williamson wrote: > > > > Nudge. Peter Xu provided an R-b for the series. Would any other mm > > folks like to chime in here to provide objection or approval for this > > change and merging it through the vfio tree? Series[1]. Thanks! > > > > Only skimmed over it, nothing jumped at me except ... > > Nitpicking: > > I was wondering if "page mask" really the right term here. I know that > we use it in some context (gup, hugetlb, zeropage) to express "mask this > off and you get the start of the aligned huge page". > > For something that walks PFNMAPs (page frames without any real "huge > page" logical metadata etc. grouping) it was uintuitive for me at first. > > addr_mask or pfn_mask (shifted addr_mask) would have been clearer for me. > > No strong opinion, just what came to mind while reading this ... It's called addr_mask in pfnmap_args_setup() so I'm happy to keep that naming if pgmask is less intuitive. Thanks, Alex
