On Fri, 17 Jan 2025 15:41:58 -0800, Sean Christopherson wrote: > Fix a flaw in the Intel PMU counters test where it asserts that an event is > counting correctly without actually knowing what the event counts given the > underlying hardware. > > The bug manifests as failures with the Top-Down Slots architectural event > when running CPUs that doesn't actually support that arch event (pre-ICX). > The arch event encoding still counts _something_, just not Top-Down Slots > (I haven't bothered to look up what it was counting). The passed by sheer > dumb luck until an unrelated change caused the count of the unknown event > to drop. > > [...] In case Paolo ends up grabbing the version I applied... https://lore.kernel.org/all/Z6_dZTbQbgr2iY6Q@xxxxxxxxxx Applied to kvm-x86 selftests_6.14. [1/5] KVM: selftests: Make Intel arch events globally available in PMU counters test https://github.com/kvm-x86/linux/commit/933178ddf73a [2/5] KVM: selftests: Only validate counts for hardware-supported arch events https://github.com/kvm-x86/linux/commit/8752e2b4a2b7 [3/5] KVM: selftests: Remove dead code in Intel PMU counters test https://github.com/kvm-x86/linux/commit/e327630e2a0c [4/5] KVM: selftests: Drop the "feature event" param from guest test helpers https://github.com/kvm-x86/linux/commit/0e6714735c01 [5/5] KVM: selftests: Print out the actual Top-Down Slots count on failure https://github.com/kvm-x86/linux/commit/54108e733444 -- https://github.com/kvm-x86/linux/tree/next