On 2/12/2025 7:34 PM, Sean Christopherson wrote: > On Wed, Feb 12, 2025, Nikunj A Dadhania wrote: >> Sean Christopherson <seanjc@xxxxxxxxxx> writes: >> Secure TSC enabled guests, as these writes are not expected to reach the >> hypervisor. Log the error and return #GP to the guest. > > Again, none of this ever says what actually happens if KVM tries to emulate a > write to MSR_IA32_TSC. Based on what the APM says, the TSC fields in the control > area are ignored. _That's_ what's relevant. > > The TSC value is first scaled with the GUEST_TSC_SCALE value from the VMSA and > then is added to the VMSA GUEST_TSC_OFFSET value. The P0 frequency, TSC_RATIO > (C001_0104h) and TSC_OFFSET (VMCB offset 50h) values are not used in the calculation. Sure, I will update the commit. Thanks, Nikunj