Oliver Upton <oliver.upton@xxxxxxxxx> writes:
Hi Colton,
On Tue, Feb 04, 2025 at 07:57:07PM +0000, Colton Lewis wrote:
asm/kvm_host.h includes asm/arm_pmu.h which includes perf/arm_pmuv3.h
which includes asm/arm_pmuv3.h which includes asm/kvm_host.h This
causes confusing compilation problems when trying to use anything in
the chain.
Break the cycle by taking asm/kvm_host.h out of asm/arm_pmuv3.h
because asm/kvm_host.h is huge and we only need a few functions from
it. Move the required declarations to asm/arm_pmuv3.h.
Signed-off-by: Colton Lewis <coltonlewis@xxxxxxxxxx>
Please do not move KVM namespaced functions into non-KVM headers. Having
a separate header for KVM<->PMUv3 driver interfaces is probably the
right thing to do, especially since you're going to be adding more with
partitioned PMU support.
That seems like a good idea to me.